Roll back protobuf to 6.32.0#265
Conversation
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe protobuf dependency constraint in ChangesProtobuf dependency update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@requirements.txt`:
- Line 6: Update the protobuf constraint in requirements.txt to raise the
minimum patch version to avoid the HIGH advisory: locate the existing
requirement line "protobuf>=6.32.0,<8" and change its lower bound to
"protobuf>=6.33.5,<8" so the resolved versions exclude the vulnerable
6.30.0rc1–6.33.4 range while remaining compatible with generated-code runtime
expectations.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
|
There is an draft PR to bring the minimim version up to protobuf 7.34.1. but that will take some time. |
|
Hi @timlaing — I have a PR open against home-assistant/core (home-assistant/core#172538) to bump pyicloud from 2.4.1 to 2.6.1 to fix the 2FA push notification regression that has affected HA users since 2026.4 (issues #166833, #166541, #167016, #167608). The blocker is the From my testing: pyicloud's Merging this PR and tagging a patch release (2.6.2?) with |
|
Doing the update now for you. Thanks |
|
@timlaing Are you going to roll back to the previous requirement for protobuf ? Happy to cancel this PR. |
|
@PaulCavill - Merging this PR now |
Signed-off-by: Tim Laing <11019084+timlaing@users.noreply.github.com>
|
Its like wack amole here. Using Python 3.14.5 environment at: venv |
|
@PaulCavill - are you going to create another PR or do you want me to do it. |
|
Will do a PR just running the Test localy first. |
Breaking change
Proposed change
Dependency downgrade to support Home Assistant
Type of change
Example of code:
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: