Skip to content

Fix newline at end of requirements.txt#268

Merged
timlaing merged 3 commits into
mainfrom
timlaing-patch-1
May 29, 2026
Merged

Fix newline at end of requirements.txt#268
timlaing merged 3 commits into
mainfrom
timlaing-patch-1

Conversation

@timlaing
Copy link
Copy Markdown
Owner

@timlaing timlaing commented May 29, 2026

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New service (thank you!)
  • New feature (which adds functionality to an existing service)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation or code sample

Example of code:

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated to README

Signed-off-by: Tim Laing <11019084+timlaing@users.noreply.github.com>
@timlaing timlaing self-assigned this May 29, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 29, 2026

Review Change Stack

Warning

Review limit reached

@timlaing, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 13 minutes and 3 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ab288df6-d9a7-4ca0-9db8-8e888c4b0956

📥 Commits

Reviewing files that changed from the base of the PR and between 7b332ed and 1b6bc3c.

📒 Files selected for processing (1)
  • requirements_cli.txt
📝 Walkthrough

Walkthrough

Pins tzlocal==5.3.1 in requirements.txt and adds/updates rich>=15.0.0 in requirements_cli.txt.

Changes

Dependency Management

Layer / File(s) Summary
Tzlocal version pinning
requirements.txt
Adds or ensures tzlocal==5.3.1 is pinned in the main requirements file.
CLI dependency: rich min version
requirements_cli.txt
Adds/updates rich>=15.0.0 in the CLI requirements file.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

A rabbit hops through lines of text,
Pinning time and styling best,
tzlocal snug at five-three-one,
rich arrives to make CLI fun,
Small changes, tidy, swiftly done. 🐰

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description contains only an unfilled contribution template with no meaningful information about the changeset, making it impossible to understand the PR's purpose from the description alone. Complete the pull request description by filling in relevant sections such as 'Proposed change' and 'Additional information' to explain the newline fix and its rationale.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: fixing the newline at the end of requirements.txt, which aligns with the commit message and file modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch timlaing-patch-1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: Tim Laing <11019084+timlaing@users.noreply.github.com>
coderabbitai[bot]
coderabbitai Bot previously approved these changes May 29, 2026
Copy link
Copy Markdown

@PaulCavill PaulCavill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how i got it to pass in my dev box

Comment thread requirements.txt
srp>=1.0.21
tinyhtml>=1.3.0
tzlocal==5.3.1 No newline at end of file
tzlocal==5.3.1
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

`tzlocal==5.3.1

`

Comment thread requirements_cli.txt
Comment on lines 1 to +3
click>=8.1.8
typer>=0.16.1
rich>=15.0.0 No newline at end of file
rich>=15.0.0
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

`click>=8.1.8
rich>=15.0.0
typer>=0.16.1

`

Copy link
Copy Markdown

@PaulCavill PaulCavill May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry not sure how to do suggested code edits in GitHub, I use DevOps daily.

@timlaing
Copy link
Copy Markdown
Owner Author

@PaulCavill - thanks. I'm struggling a little bit as I am trying to do this on my mobile as I am away camping atm. I'll have this sorted in the next few minutes though

@timlaing timlaing marked this pull request as ready for review May 29, 2026 11:48
Copilot AI review requested due to automatic review settings May 29, 2026 11:48
@timlaing timlaing merged commit 00312c4 into main May 29, 2026
20 of 22 checks passed
@timlaing timlaing deleted the timlaing-patch-1 branch May 29, 2026 11:48
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@PaulCavill
Copy link
Copy Markdown

@PaulCavill - thanks. I'm struggling a little bit as I am trying to do this on my mobile as I am away camping atm. I'll have this sorted in the next few minutes though

Thank you for doing this, I have some spare time on sunday, will see if i can add the format checking to the forced pre commit stage. then these issues shouldn't make it to the PR stage.

@PaulCavill
Copy link
Copy Markdown

PaulCavill commented May 29, 2026

@timlaing Good News. We are now passing the HA requirements check.

image

@timlaing
Copy link
Copy Markdown
Owner Author

@PaulCavill Thanks for your help on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants