Skip to content

Code improvements #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timok19 merged 1 commit into from
Mar 8, 2026
Merged

Code improvements #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion AffirmationGenerator.Client/vite.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@ export default defineConfig(function (_a) {
var httpsConfig = undefined;
// Setup https certificates for local development
if (command === "serve") {
var baseFolder = env.APPDATA !== undefined && env.APPDATA !== "" ? "".concat(env.APPDATA, "/ASP.NET/https") : "".concat(env.HOME, "/.aspnet/https");
var baseFolder = env.APPDATA !== undefined && env.APPDATA !== ""
? "".concat(env.APPDATA, "/ASP.NET/https")
: "".concat(env.HOME, "/.aspnet/https");
var certificateName = "reactapp1.client";
var certFilePath = path.join(baseFolder, "".concat(certificateName, ".pem"));
var keyFilePath = path.join(baseFolder, "".concat(certificateName, ".key"));
Expand Down
15 changes: 11 additions & 4 deletions AffirmationGenerator.Client/vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,10 @@ export default defineConfig(({ command }) => {

// Setup https certificates for local development
if (command === "serve") {
const baseFolder = env.APPDATA !== undefined && env.APPDATA !== "" ? `${env.APPDATA}/ASP.NET/https` : `${env.HOME}/.aspnet/https`;
const baseFolder =
env.APPDATA !== undefined && env.APPDATA !== ""
? `${env.APPDATA}/ASP.NET/https`
: `${env.HOME}/.aspnet/https`;

const certificateName = "reactapp1.client";
const certFilePath = path.join(baseFolder, `${certificateName}.pem`);
Expand All @@ -33,9 +36,13 @@ export default defineConfig(({ command }) => {
if (!fs.existsSync(certFilePath) || !fs.existsSync(keyFilePath)) {
if (
0 !==
child_process.spawnSync("dotnet", ["dev-certs", "https", "--export-path", certFilePath, "--format", "Pem", "--no-password"], {
stdio: "inherit",
}).status
child_process.spawnSync(
"dotnet",
["dev-certs", "https", "--export-path", certFilePath, "--format", "Pem", "--no-password"],
{
stdio: "inherit",
},
).status
) {
throw new Error("Could not create certificate.");
}
Expand Down
10 changes: 6 additions & 4 deletions AffirmationGenerator.Server.Tests/Extensions/NSubstituteExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,11 @@ namespace AffirmationGenerator.Server.Tests.Extensions;

public static class NSubstituteExtensions
{
public static ConfiguredCall ReturnsSuccess<T>(this Task<Result<T>> value, T returnThis) =>
value.Returns(Result<T>.Success(returnThis));
extension<T>(Task<Result<T>> value)
{
public ConfiguredCall ReturnsSuccess(T returnThis) => value.Returns(Result<T>.Success(returnThis));

public static ConfiguredCall ReturnsError<TValue, TError>(this Task<Result<TValue>> value)
where TError : ErrorDetails, new() => value.Returns(Result<TValue>.Error(new TError()));
public ConfiguredCall ReturnsError<TError>()
where TError : ErrorDetails, new() => value.Returns(Result<T>.Error(new TError()));
}
}
18 changes: 6 additions & 12 deletions AffirmationGenerator.Server/Api/DiConfig.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,18 +13,12 @@ public static class DiConfig
{
extension(IServiceCollection services)
{
public IServiceCollection AddApi()
{
services.AddControllers();
services.AddOpenApi();
services.AddRateLimiting();
services.ConfigureHttpJsonOptions(options =>
{
options.SerializerOptions.Converters.Add(new JsonStringEnumConverter());
});

return services;
}
public IServiceCollection AddApi() =>
services
.AddControllers()
.Services.AddOpenApi()
.AddRateLimiting()
.ConfigureHttpJsonOptions(options => options.SerializerOptions.Converters.Add(new JsonStringEnumConverter()));

private IServiceCollection AddRateLimiting() =>
services.AddRateLimiter(rateLimiterOptions =>
Expand Down