docs(agents): document e2e:all and warn against raw playwright test (PP-278)#1286
Merged
timothyfroehlich merged 4 commits intomainfrom May 5, 2026
Merged
docs(agents): document e2e:all and warn against raw playwright test (PP-278)#1286timothyfroehlich merged 4 commits intomainfrom
timothyfroehlich merged 4 commits intomainfrom
Conversation
…PP-278) Updates AGENTS.md section 4 "Which Tests to Run": - Reframes item 6 from "NEVER run e2e:full" to "NEVER run e2e:full directly during iteration" — the new e2e:all wraps it as part of a legitimate pre-review pass. - Adds item 7 documenting `pnpm run e2e:all` (introduced in PP-6dp) for the "want everything locally before review" case, with explicit ~10-15 min runtime and a note that each suite runs in its own Playwright invocation with a fresh global-setup between them. - Adds item 8 warning against `pnpm exec playwright test` without --config= — picks up all specs at once and cross-contaminates state. Pointers to e2e:all as the safe alternative. No code changes. Depends on PP-6dp (PR #1285) landing first so the referenced script exists. Refs PP-2on (epic). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the agent workflow documentation in AGENTS.md to better reflect the intended local E2E testing strategy (avoid full-suite runs during iteration, but provide a safe “run everything” option via e2e:all).
Changes:
- Rewords guidance around avoiding
e2e:fullduring normal iteration. - Documents
pnpm run e2e:allas the “run everything locally before review” option, including expected runtime and isolation rationale. - Adds a warning about unsafe raw Playwright invocations that can accidentally run all E2E specs in one process and contaminate state.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
timothyfroehlich
added
the
ready-for-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates AGENTS.md section 4 "Which Tests to Run":
e2e:full" to "NEVER rune2e:fulldirectly during iteration" — the newe2e:allwraps it as part of a legitimate pre-review pass.pnpm run e2e:all(introduced in PP-6dp / feat(e2e): isolated all-E2E runner script (PP-6dp) #1285) for the "want everything locally before review" case, with explicit ~10–15 min runtime and a note that each suite runs in its own Playwright invocation with a freshglobal-setupbetween them.pnpm exec playwright testwithout--config=— picks up all specs at once and cross-contaminates state. Points toe2e:allas the safe alternative.No code changes.
Dependency
Depends on PR #1285 (PP-6dp) landing first so the referenced
pnpm run e2e:allscript exists. If this lands first, the docs would describe a non-existent command.Inherited CI failures
mainis currently red. Inherited failures from main (PP-q9r/PP-e20/PP-jsh/PP-v7g/PP-49m) will appear in CI; not introduced by this PR. See Tim's status comment on PR #1278.Test plan
pnpm run checkpasses (1013 unit tests)screenshotreferences remaining in AGENTS.md / CLAUDE.md /.agent/skills/(PR chore(e2e): remove unused screenshots tests and workflows (PP-ekq) #1278 already cleaned up; verified one remaining match is for Playwright debug screenshots, not the deleted suite)Related
.env.local(PP-uc8 redesign) #1283, feat(e2e): browser+Docker preflight in global-setup (PP-cao) #1284, feat(e2e): isolated all-E2E runner script (PP-6dp) #1285🤖 Generated with Claude Code