chore(workflow): add readiness audit to pr-watch.py (PP-watch)#1287
Open
timothyfroehlich wants to merge 4 commits intomainfrom
Open
chore(workflow): add readiness audit to pr-watch.py (PP-watch)#1287timothyfroehlich wants to merge 4 commits intomainfrom
timothyfroehlich wants to merge 4 commits intomainfrom
Conversation
Adds a pre-flight audit to `pr-watch.py` that blocks if the PR is behind 'main' or has unresolved Copilot comments. This prevents 'piling up' of comments by ensuring agents address existing feedback and merge main before entering the wait-for-review state. - Checks `behind_by` via GitHub Compare API (more robust than mergeStateStatus) - Checks unresolved Copilot threads via GraphQL - Adds `--force` flag to bypass checks when needed
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a pre-flight readiness audit to pr-watch.py so the watcher can fail early when a PR should not enter the review-wait loop yet.
Changes:
- Adds CLI support for an optional
--forceflag and updates argument parsing. - Fetches additional PR metadata, then performs a readiness audit before the watch loop starts.
- Blocks watching when the PR is behind
mainor has unresolved Copilot review threads, unless--forceis used.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
- pr-watch.py now paginates the reviewThreads GraphQL query via pageInfo.hasNextPage cursor, so PRs with >100 review threads are audited completely. Previously the readiness audit only inspected the first 100 threads, silently missing unresolved Copilot feedback on large PRs (e.g. #1270 has 33 active threads, more accumulate over time). - Fixes ruff F541 (extraneous f-prefix) errors that broke Fast Linters on the prior commit. Addresses GitHub Copilot review comments on PR #1287.
timothyfroehlich
added
the
ready-for-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a pre-flight audit to
pr-watch.pythat blocks if the PR is behind 'main' or has unresolved Copilot comments. This prevents 'piling up' of comments by ensuring agents address existing feedback and merge main before entering the wait-for-review state.Changes
behind_byvia GitHub Compare API and unresolved Copilot threads via GraphQL before starting the watch loop.--forceto bypass checks when necessary.Verified locally against PR #1270.