test(e2e): verify PP-awg absorption (PP-jsh + PP-v7g)#1291
Draft
timothyfroehlich wants to merge 2 commits intomainfrom
Draft
test(e2e): verify PP-awg absorption (PP-jsh + PP-v7g)#1291timothyfroehlich wants to merge 2 commits intomainfrom
timothyfroehlich wants to merge 2 commits intomainfrom
Conversation
Removes test.fixme calls for the Radix DropdownMenu (logout) and Radix Select (status) flake clusters. PP-awg (#1280) bumped Playwright's actionTimeout to 30s in CI; this experiment confirms whether that absorbed the portal mount timing variance. Affected: - e2e/full/machine-details-extended.spec.ts (4 tests using logout()) → PP-jsh - e2e/full/status-overhaul.spec.ts (1 test using Status Select) → PP-v7g If CI passes cleanly: PP-awg absorbed the flakes; close PP-jsh and PP-v7g. If CI flakes: revert this commit and file Layer 2 (per-spec helpers). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PR #1290 silenced 5 broken specs via
test.fixme. PR #1280 (PP-awg) bumped Playwright'sactionTimeoutfrom 5s to 30s in CI, hypothesizing it would absorb the Radix portal mount timing variance behind PP-jsh and PP-v7g.This PR unsilences those 5 tests so CI runs them. The result tells us whether to retire the beads (PP-awg absorbed) or open Layer 2 (per-spec helpers).
Decision rule
Tests unsilenced
logout()(DropdownMenu portal) → PP-jshTracking
Test plan