Fix check for superfences config when loaded via pymdownx.extra#26
Merged
Conversation
The check for the `superfences` config failed when `superfences` was loaded by `pymdownx.extra`. In particular, this means that the plugin failed to work with the defaults set up by Spotify's `techdocs-core` plugin. In this PR, the check is adapted to also check for the `pymdownx.superfences` configuration inside the `pymdownx.extra` configuration.
Owner
|
Thanks! |
Owner
|
We're actually using backstage at the company I'm at currently (allianz partners) 👍🏻 |
Owner
|
New version is on pypi! |
Contributor
Author
|
Thanks for the quick action! Just getting started with backstage here at Picnic, and was very happy to find this plugin! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check for the
superfencesconfig failed whensuperfenceswas loaded bypymdownx.extra. In particular, this means that the plugin failed to work with the defaults set up by Spotify'stechdocs-coreplugin. In this PR, the check is adapted to also check for thepymdownx.superfencesconfiguration inside thepymdownx.extraconfiguration.