fix(radio): check for negative credential lengths#49
Open
deadprogram wants to merge 1 commit into
Open
Conversation
Reject negative ssid_len and pwd_len in station and AP configurations to prevent integer/cast wrap-around that causes out-of-bounds memcpy. Orginally suggested by PR #48 thanks! Signed-off-by: deadprogram <ron@hybridgroup.com>
b0ch3nski
reviewed
Jun 8, 2026
| } | ||
| wifi_config_t cfg; | ||
| memset(&cfg, 0, sizeof(cfg)); | ||
| if (ssid_len > 32) ssid_len = 32; |
There was a problem hiding this comment.
Hmm, this also uncovers the silent ignore for ssid/pass longer than expected being just truncated to 32/64 chars - wouldn't it be better to return error here also? (and probably check this in user code for nicer errors?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject negative ssid_len and pwd_len in station and AP configurations to prevent integer/cast wrap-around that causes out-of-bounds memcpy.
Orginally suggested by PR #48 thanks!