Skip to content

compiler: disambiguate function-local named types #5336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jakebailey wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

compiler: disambiguate function-local named types #5336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
924ff91
compiler: make getTypeCodeName a method on compilerContext
jakebailey Apr 21, 2026
292f314
testdata: add regression tests for function-local named types
jakebailey Apr 21, 2026
d05e0b7
compiler: disambiguate function-local named types
jakebailey Apr 21, 2026
d0cf28b
Kill off the second pass
jakebailey Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions compiler/compiler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ type compilerContext struct {
pkg *types.Package
packageDir string // directory for this package
runtimePkg *types.Package
localTypeNames typeutil.Map // *types.Named (synthetic local from generic instantiation) -> string
}

// newCompilerContext returns a new compiler context ready for use, most
Expand Down Expand Up @@ -300,6 +301,11 @@ func CompilePackage(moduleName string, pkg *loader.Package, ssaPkg *ssa.Package,
// Convert AST to SSA.
ssaPkg.Build()

// Assign names to function-local named types before compiling the
// package, so that types declared in different functions (or in
// different instantiations of a generic function) do not collide.
c.scanLocalTypes(ssaPkg)

// Initialize debug information.
if c.Debug {
c.cu = c.dibuilder.CreateCompileUnit(llvm.DICompileUnit{
Expand Down
Loading
Loading