Remove bundled WDK7 stdint.h compatibility header#8
Merged
Conversation
The setup action should not inject a CRT polyfill into every consumer's include path. Bundling stdint.h silently shadows headers and makes downstream builds depend on an invisible header owned by the action. Providing a stdint.h shim is the downstream project's responsibility. - Delete include/stdint.h and the include/ directory - Drop WDK7_COMPAT_INCLUDE_DIR wiring from the CMake toolchain - Remove the compatibility-header feature line from README - Revert the e2e exe fixture to not depend on <stdint.h>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The setup action should not inject a CRT polyfill into every consumer's include path. Bundling
stdint.hsilently shadows headers and makes downstream builds depend on an invisible header owned by the action. Providing astdint.hshim is the downstream project's responsibility.Changes
include/stdint.hand the now-emptyinclude/directoryWDK7_COMPAT_INCLUDE_DIRderivation and its entries inWDK7_USER_INCLUDE_DIRS/WDK7_KERNEL_INCLUDE_DIRSfromcmake/wdk7.cmakeREADME.mdexe.cfixture to not depend on<stdint.h>