Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new Rust cdylib (liblogjet) exposing a small C ABI for exporting OTLP logs, plus a C++ demo that loads the shared library and sends logs into ljd. Also enhances ljx view to display OTLP resource/record attributes in the modal info view (with styling) and adds tests around attribute listing.
Changes:
- Introduce
liblogjetcrate with C ABI (HTTP + gRPC OTLP exporters) and a public C header. - Add a C++ shared-library demo (script + config + sample logger) to exercise the FFI flow end-to-end.
- Update
ljx viewmodal info to enumerate OTLP attributes and visually distinguish “standard” vs custom attributes; add test coverage.
Reviewed changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| ljx/src/commands/view.rs | List OTLP attributes in the info modal, add formatting/styling helpers, add tests |
| liblogjet/src/lib.rs | New Rust cdylib providing C ABI to emit OTLP logs over HTTP/gRPC |
| liblogjet/include/liblogjet.h | Public C header for the FFI API |
| liblogjet/Cargo.toml | New crate manifest configuring cdylib build and deps |
| demo/cpp-shared-lib/run-demo.sh | Script to build/run the C++ demo and open ljx view |
| demo/cpp-shared-lib/ljd.conf | Demo config for file-backed ingestion via OTLP/gRPC |
| demo/cpp-shared-lib/liblogjet.so | Checked-in symlink/path intended to point at built shared object |
| demo/cpp-shared-lib/cpp-logger.cpp | C++ example that dlopens the library and emits logs |
| demo/cpp-shared-lib/README.md | Demo documentation/instructions |
| demo/README.md | Add demo entry point to the demo index |
| Cargo.toml | Add liblogjet to the workspace members |
Comments suppressed due to low confidence (1)
demo/cpp-shared-lib/liblogjet.so:1
- This appears to be a committed symlink (or symlink-like file) pointing to an absolute, machine-specific path under
/home/.... That will be invalid for other developers/CI. Sincerun-demo.shalready creates the symlink vialn -sf, it’s better to remove this from version control and add it to.gitignore, or commit a relative symlink target (e.g.,../../target/debug/libliblogjet.so) if you really want it present in the repo.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To C/C++ fellas: take it nice and easy! 😉