Polish: album-art accent + liquid-glass clock + blurred backdrop #10
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,62 @@ | ||||||||||||||||||||||||
| import AppKit | ||||||||||||||||||||||||
| import SwiftUI | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| extension NSImage { | ||||||||||||||||||||||||
| /// A vibrant accent color sampled from the album art, used to tint the glass | ||||||||||||||||||||||||
| /// edge glow and the current lyric line on both surfaces (creative polish, | ||||||||||||||||||||||||
| /// PRD "dynamic album-art accent color"). | ||||||||||||||||||||||||
| /// | ||||||||||||||||||||||||
| /// Downsamples to a small bitmap, averages the reasonably saturated, | ||||||||||||||||||||||||
| /// mid-bright pixels (so near-black/near-white backgrounds don't dominate), | ||||||||||||||||||||||||
| /// then normalizes saturation/brightness so the result always reads as an | ||||||||||||||||||||||||
| /// accent rather than a muddy or washed-out tone. Falls back to white. | ||||||||||||||||||||||||
| func accentColor() -> Color { | ||||||||||||||||||||||||
| let side = 24 | ||||||||||||||||||||||||
| guard let rep = downsampledBitmap(side: side) else { return .white } | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| var rSum = 0.0, gSum = 0.0, bSum = 0.0, weight = 0.0 | ||||||||||||||||||||||||
| for y in 0..<side { | ||||||||||||||||||||||||
| for x in 0..<side { | ||||||||||||||||||||||||
| guard let pixel = rep.colorAt(x: x, y: y)?.usingColorSpace(.sRGB) else { continue } | ||||||||||||||||||||||||
| let s = Double(pixel.saturationComponent) | ||||||||||||||||||||||||
| let v = Double(pixel.brightnessComponent) | ||||||||||||||||||||||||
| // Favor colorful, mid-bright pixels; heavily discount flat | ||||||||||||||||||||||||
| // dark/bright areas (letterboxing, white sleeves, shadows). | ||||||||||||||||||||||||
| let w = s * ((v > 0.12 && v < 0.97) ? 1.0 : 0.08) | ||||||||||||||||||||||||
| rSum += Double(pixel.redComponent) * w | ||||||||||||||||||||||||
| gSum += Double(pixel.greenComponent) * w | ||||||||||||||||||||||||
| bSum += Double(pixel.blueComponent) * w | ||||||||||||||||||||||||
| weight += w | ||||||||||||||||||||||||
| } | ||||||||||||||||||||||||
| } | ||||||||||||||||||||||||
| guard weight > 0.0001 else { return .white } | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| let base = NSColor( | ||||||||||||||||||||||||
| srgbRed: rSum / weight, green: gSum / weight, blue: bSum / weight, alpha: 1 | ||||||||||||||||||||||||
| ) | ||||||||||||||||||||||||
| // Normalize so the tint always pops, even from desaturated art. | ||||||||||||||||||||||||
| let boosted = NSColor( | ||||||||||||||||||||||||
| hue: base.hueComponent, | ||||||||||||||||||||||||
| saturation: min(max(base.saturationComponent, 0.55), 0.9), | ||||||||||||||||||||||||
| brightness: max(base.brightnessComponent, 0.78), | ||||||||||||||||||||||||
| alpha: 1 | ||||||||||||||||||||||||
| ) | ||||||||||||||||||||||||
| return Color(nsColor: boosted) | ||||||||||||||||||||||||
| } | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| private func downsampledBitmap(side: Int) -> NSBitmapImageRep? { | ||||||||||||||||||||||||
| guard let rep = NSBitmapImageRep( | ||||||||||||||||||||||||
| bitmapDataPlanes: nil, pixelsWide: side, pixelsHigh: side, | ||||||||||||||||||||||||
| bitsPerSample: 8, samplesPerPixel: 4, hasAlpha: true, isPlanar: false, | ||||||||||||||||||||||||
| colorSpaceName: .deviceRGB, bytesPerRow: 0, bitsPerPixel: 0 | ||||||||||||||||||||||||
| ) else { return nil } | ||||||||||||||||||||||||
| rep.size = NSSize(width: side, height: side) | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| NSGraphicsContext.saveGraphicsState() | ||||||||||||||||||||||||
| NSGraphicsContext.current = NSGraphicsContext(bitmapImageRep: rep) | ||||||||||||||||||||||||
| draw(in: NSRect(x: 0, y: 0, width: side, height: side), | ||||||||||||||||||||||||
| from: .zero, operation: .copy, fraction: 1) | ||||||||||||||||||||||||
| NSGraphicsContext.restoreGraphicsState() | ||||||||||||||||||||||||
|
Comment on lines
+55
to
+59
There was a problem hiding this comment. In AppKit,
Suggested change
|
||||||||||||||||||||||||
| return rep | ||||||||||||||||||||||||
| } | ||||||||||||||||||||||||
| } | ||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Downsampling to a 24x24 grid requires 576 iterations of
colorAt(x:y:)andusingColorSpace(.sRGB)on the main thread, which is highly inefficient and can cause noticeable UI micro-stutters during track changes.By reducing the downsample size to
12(144 pixels) and removing the redundant.usingColorSpace(.sRGB)call (since the bitmap is already initialized indeviceRGB), we can achieve a virtually identical accent color with a fraction of the CPU overhead.