-
Notifications
You must be signed in to change notification settings - Fork 0
Phase 6: lock-screen now-playing widget #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tirthfx
wants to merge
1
commit into
phase-5-lockscreen-shell
Choose a base branch
from
phase-6-lockscreen-widget
base: phase-5-lockscreen-shell
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
85 changes: 85 additions & 0 deletions
85
NotchBeat/PseudoLockScreenController/LockScreenNowPlayingWidget.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| import AppKit | ||
| import SwiftUI | ||
|
|
||
| /// The compact now-playing widget on the lock screen (PRD §3.2 L1, reference | ||
| /// image 1): a frosted card floating over the wallpaper with album art, track | ||
| /// info, a scrubber, and transport controls. Reuses `ScrubberView` (from the | ||
| /// notch player) so the progress bar / drag-to-seek behaves identically. | ||
| struct LockScreenNowPlayingWidget: View { | ||
| let nowPlaying: NowPlaying | ||
| let albumArt: NSImage? | ||
| let onPlayPause: () -> Void | ||
| let onPrevious: () -> Void | ||
| let onNext: () -> Void | ||
| let onSeek: (TimeInterval) -> Void | ||
|
|
||
| var body: some View { | ||
| VStack(spacing: 14) { | ||
| HStack(spacing: 12) { | ||
| artwork | ||
| .frame(width: 56, height: 56) | ||
| .clipShape(RoundedRectangle(cornerRadius: 8, style: .continuous)) | ||
| VStack(alignment: .leading, spacing: 2) { | ||
| Text(nowPlaying.title) | ||
| .font(.system(size: 15, weight: .semibold)) | ||
| .foregroundStyle(.white) | ||
| Text(nowPlaying.artist) | ||
| .font(.system(size: 13)) | ||
| .foregroundStyle(.white.opacity(0.65)) | ||
| } | ||
| .lineLimit(1) | ||
| Spacer(minLength: 0) | ||
| } | ||
|
|
||
| ScrubberView(nowPlaying: nowPlaying, onSeek: onSeek, onActivity: {}) | ||
|
|
||
| HStack(spacing: 40) { | ||
| transportButton("backward.fill", size: 18, action: onPrevious) | ||
| transportButton(nowPlaying.isPlaying ? "pause.fill" : "play.fill", size: 26, action: onPlayPause) | ||
| .contentTransition(.symbolEffect(.replace)) | ||
| transportButton("forward.fill", size: 18, action: onNext) | ||
| } | ||
| } | ||
| .padding(18) | ||
| .frame(width: 340) | ||
| .background { | ||
| let shape = RoundedRectangle(cornerRadius: 22, style: .continuous) | ||
| // Frosted glass + a dark tint so white text stays legible over any | ||
| // wallpaper (bright or dark). | ||
| ZStack { | ||
| shape.fill(.ultraThinMaterial) | ||
| shape.fill(.black.opacity(0.28)) | ||
| } | ||
| } | ||
| .clipShape(RoundedRectangle(cornerRadius: 22, style: .continuous)) | ||
| .shadow(color: .black.opacity(0.35), radius: 24, y: 8) | ||
| } | ||
|
|
||
| @ViewBuilder | ||
| private var artwork: some View { | ||
| if let albumArt { | ||
| Image(nsImage: albumArt) | ||
| .resizable() | ||
| .aspectRatio(contentMode: .fill) | ||
| } else { | ||
| RoundedRectangle(cornerRadius: 8, style: .continuous) | ||
| .fill(Color(white: 0.25)) | ||
| .overlay { | ||
| Image(systemName: "music.note") | ||
| .font(.system(size: 24, weight: .medium)) | ||
| .foregroundStyle(.white.opacity(0.8)) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private func transportButton(_ symbol: String, size: CGFloat, action: @escaping () -> Void) -> some View { | ||
| Button(action: action) { | ||
| Image(systemName: symbol) | ||
| .font(.system(size: size, weight: .semibold)) | ||
| .foregroundStyle(.white.opacity(0.95)) | ||
| .frame(width: size + 18, height: size + 14) | ||
| .contentShape(Rectangle()) | ||
| } | ||
| .buttonStyle(.plain) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
.position(x:y:)in SwiftUI causes the modified views to expand and occupy the entire available space of their parent container (the full screen insideGeometryReader). This can interfere with hit-testing, potentially blocking user interactions (such as 'click-away' dismissal) on the backgroundWallpaperVieweven in areas that appear empty.Using
.offset(y:)with a top-alignedZStackis a safer and more idiomatic alternative because it shifts the views' rendering without expanding their layout bounds to fill the screen.