Skip to content

Fix cannot patch migration job #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
loyal2thesea wants to merge 3 commits into
base: add-documentation
Choose a base branch
from
Open

Fix cannot patch migration job #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
973a5c9
add helm hook annotations to fix jobs being unable be patched
loyal2thesea Feb 20, 2026
56e667f
update changelog
loyal2thesea Feb 20, 2026
dc7b619
changelog again
loyal2thesea Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion charts/generic-service/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,12 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),

## [Unreleased]

## [2.0.1-rc.1] - 2026-02-20

### Fixed

- Migrations job now runs as a Helm hook (`pre-install,pre-upgrade`) with `before-hook-creation` delete policy, preventing "cannot patch" errors when re-deploying a release that already has a completed migrations job.

## [2.0.0-alpha] - 2025-07-25

### Added
Expand Down Expand Up @@ -726,7 +732,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),

---

[Unreleased]: https://github.com/tithely/helm-charts/compare/generic-service-2.0.0-alpha...HEAD
[Unreleased]: https://github.com/tithely/helm-charts/compare/generic-service-2.0.1-rc.1...HEAD
[2.0.1-rc.1]: https://github.com/tithely/helm-charts/compare/generic-service-2.0.0-alpha...generic-service-2.0.1-rc.1
[2.0.0-alpha]: https://github.com/tithely/helm-charts/compare/generic-service-1.1.6-delta...generic-service-2.0.0-alpha
[1.1.6-delta]: https://github.com/tithely/helm-charts/compare/generic-service-1.1.6-charlie...generic-service-1.1.6-delta
[1.1.6-charlie]: https://github.com/tithely/helm-charts/compare/generic-service-1.1.6-beta...generic-service-1.1.6-charlie
Expand Down
2 changes: 1 addition & 1 deletion charts/generic-service/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v2
name: generic-service
description: A Helm chart for Kubernetes
version: 2.0.0-alpha
version: 2.0.1-rc.1
dependencies:
- name: memcached
version: 6.6.x
Expand Down
2 changes: 1 addition & 1 deletion charts/generic-service/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# generic-service

![Version: 2.0.0-alpha](https://img.shields.io/badge/Version-2.0.0--alpha-informational?style=flat-square)
![Version: 2.0.1-rc.1](https://img.shields.io/badge/Version-2.0.1--rc.1-informational?style=flat-square)

A Helm chart for Kubernetes

Expand Down
3 changes: 3 additions & 0 deletions charts/generic-service/templates/migrations-job.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ metadata:
name: {{ $value.name }}
generateName: {{ $.Release.Namespace }}-migrations-job-
namespace: {{ $.Release.Namespace }}
annotations:
"helm.sh/hook": pre-install,pre-upgrade
"helm.sh/hook-delete-policy": before-hook-creation
spec:
ttlSecondsAfterFinished: 60
backoffLimit: 4
Expand Down