Fix how kwargs are handled with a request#3
Open
trevorflahardy wants to merge 5 commits intotixte:mainfrom
trevorflahardy:main
Open
Fix how kwargs are handled with a request#3trevorflahardy wants to merge 5 commits intotixte:mainfrom trevorflahardy:main
trevorflahardy wants to merge 5 commits intotixte:mainfrom
trevorflahardy:main
Conversation
Was missing `**` in the initial commit, fixed to be nicer. I would ultimately like to format the params onto the url to be all one str, but I'm thinkin about the best way to do that, and will change it later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kwargs would not get processed correctly, I've fixed it so they do.
Originally I had added two
**to the big dict of kwargs, but I removed that and separated it into two lines... looks better.Also removed the two comment lines at the bottom, not needed.