fix: ui consistency when rejecting/approving events#1886
Open
ZamanZahid wants to merge 1 commit into
Open
Conversation
|
coverage: 79.259% (+0.007%) from 79.252% — ZamanZahid:dev into tjcsl:dev |
aarushtools
requested changes
May 12, 2026
| logger.info("Admin %s approved event: %s (%s)", request.user, event, event.id) | ||
| query_string = request.GET.urlencode() | ||
| url = f"{reverse('events')}?{query_string}" if query_string else reverse("events") | ||
| return redirect(url) |
Member
There was a problem hiding this comment.
you can make this a lot simpler if you use the request object
Author
|
I simplified it using the request object and pushed the update. |
aarushtools
requested changes
May 13, 2026
Author
|
great, lmk if it's good. |
aarushtools
previously approved these changes
May 15, 2026
ZamanZahid
force-pushed
the
dev
branch
3 times, most recently
from
945c68a to
8a528f2
Compare
Author
|
Finished |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1825
Proposed changes
keeps ?show=all, after approve/reject