Skip to content

feat: add new years themed logo#1897

Open
tonymac129 wants to merge 5 commits into
tjcsl:devfrom
tonymac129:feature/new-years
Open

feat: add new years themed logo#1897
tonymac129 wants to merge 5 commits into
tjcsl:devfrom
tonymac129:feature/new-years

Conversation

@tonymac129

@tonymac129 tonymac129 commented May 10, 2026

Copy link
Copy Markdown
Member

Proposed changes

  • Add new years fireworks Ion logo overlay
  • Add fireworks animation trigger button

Brief description of rationale

@tonymac129 tonymac129 requested a review from a team as a code owner May 10, 2026 04:27
@tonymac129 tonymac129 changed the title feat: add new years themed logo #1895 feat: add new years themed logo May 10, 2026
@coveralls

coveralls commented May 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Coverage Status

coverage: 79.252% (-0.01%) from 79.264% — tonymac129:feature/new-years into tjcsl:dev

aarushtools
aarushtools requested changes May 12, 2026
View reviewed changes

@aarushtools aarushtools left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Tony,

Great start on this PR! I like the firework button addition. Right now the colorful fireworks on the logo are a little hard to see - maybe too dark? Can you try adjusting the contrast to make it look nicer. Thanks

Comment thread intranet/static/themes/new_years/new_years.js Outdated
}
});

$(".intranet-title-text").html(`Ion <img id="fireworks-btn" src="${path}new_years_party_popper.png" />`);

@aarushtools aarushtools May 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a comment around line 50-55 of page_with_header.html saying that the ion new years html is edited through this file so people arent confused when looking at it

@tonymac129

tonymac129 commented May 13, 2026

Copy link
Copy Markdown
Member Author

Hi Aarush,
I increased the size, brightness, and contrast of the fireworks to improve visibility and added the comment to clarify how the logo is updated. Is there anything else I need to change?

@aarushtools

aarushtools commented May 13, 2026

Copy link
Copy Markdown
Member

Hi Tony,

Sorry can you do a few more changes stylistically -
I'm not sure I like the look of the Ion background too much, can you think of a different approach to the design? I would recommend going into something like Photopea and trying to design a new years logo for Ion that looks stylish and colorful. Aarush Deshpande suggested that perhaps there should be confetti behind the logo instead of the fireworks on it right now. You're free to do what you want stylistically though, I'd just prefer a different approach than the current one.

Codewise your PR looks great, good job!

@tonymac129

tonymac129 commented May 16, 2026

Copy link
Copy Markdown
Member Author

Hi Aarush,
Sorry for responding so late, but could this logo work? I kept the original Ion logo shapes but tried to make it look more like a colorful confetti popper. I'm not that good with graphic design, so please tell me where I can improve the logo, thanks.
image

@aarushtools

aarushtools commented May 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Yes, that looks great! I like the creativity there. Just make sure the Ion text isn't too spaced apart from the confetti
you can also make that the fireworks button if you weren't already

@tonymac129

tonymac129 commented May 16, 2026

Copy link
Copy Markdown
Member Author

I updated the logo and replaced the fireworks button with it like you suggested

@tonymac129 tonymac129 requested a review from aarushtools May 18, 2026 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aarushtools aarushtools Awaiting requested review from aarushtools

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ion new years logo change

3 participants

@tonymac129 @coveralls @aarushtools