Gmg preconditioner#15
Conversation
| */ | ||
| template <class PreconditionerA> | ||
| template <class PreconditionerA, class VectorType, class StokesMatrixType> | ||
| class InverseVelocityBlock |
There was a problem hiding this comment.
This only exists in solver.cc and won't be visible to GMG unless you move it to the header...
There was a problem hiding this comment.
maybe a first PR would only make this change and introduce the template arguments.
| *Implements the vmult for InverseVelocityBlock. | ||
| */ | ||
| template <class PreconditionerA, class VectorType, class StokesMatrixType> | ||
| void InverseVelocityBlock<PreconditionerA,VectorType,StokesMatrixType>::vmult(VectorType &dst, |
There was a problem hiding this comment.
also needs to be in the header
| * @param A_block_tolerance The tolerance for the CG solver which computes | ||
| * the inverse of the A block. | ||
| */ | ||
| InverseVelocityBlock(const StokesMatrixType &matrix, |
There was a problem hiding this comment.
the name StokesMatrixType is misleading. Shouldn't it be ABlockType, VelocityBlockType or AMatrixType or something?
| * @param do_solve_A A flag indicating whether we should actually solve with | ||
| * the matrix $A$, or only apply one preconditioner step with it. | ||
| * @param A_block_is_symmetric A flag indicating whether the matrix $A$ is symmetric. | ||
| * @param A_block_tolerance The tolerance for the CG solver which computes |
There was a problem hiding this comment.
you will need to fix these comments
23ebc30 to
bf05669
Compare
|
Missing include: |
|
you need to update test output: |
4cb9ca7 to
4f98075
Compare
c893790 to
0a35ab6
Compare
Pull Request Checklist. Please read and check each box with an X. Delete any part not applicable. Ask on the forum if you need help with any step.
Describe what you did in this PR and why you did it.
Before your first pull request:
For all pull requests:
For new features/models or changes of existing features: