Open
Conversation
added 14 commits
April 6, 2018 15:24
Default of 80 is very small, so let's go with 100.
Need ExitStack (Python3 only) for variable number of output files, so have marked that for future migration.
Reuse the NucProcess.open_file_r function.
Begin work on refactoring output handling
Doesn't check the output, just that it runs successfully
pytest-flake8 seems to have some issues with ignores behaving differently locally and on Travis-CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main test is smoke testing NucProcess (i.e. just that it runs without errors) and associated fixes. Also Fixes some issues in merge_file_names that I ran into. Tests are OK.