Skip to content

NativeScript 7 compatibility #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
grey280 wants to merge 7 commits into
base: master
Choose a base branch
from
Open

NativeScript 7 compatibility #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5c4ae00
Update dependencies for NS 7
grey280 Sep 23, 2020
58c0bba
Update reference to @nativescript/types
grey280 Sep 23, 2020
7977bb0
Update imports to @nativescript/core
grey280 Sep 23, 2020
8e908c5
Bump version
grey280 Sep 23, 2020
c4fe775
Bump ES version for NS7 compatibility
grey280 Sep 23, 2020
7c6db21
Fix tabs/spaces issue
grey280 Oct 12, 2020
f33ac85
Update TSconfig
grey280 Oct 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/iqkeyboardmanager.android.ts
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { ContentView } from "tns-core-modules/ui/content-view";
import { TextView } from "tns-core-modules/ui/text-view";
import { ContentView, TextView } from "@nativescript/core";

export class PreviousNextView extends ContentView {
}
Expand Down
3 changes: 1 addition & 2 deletions src/iqkeyboardmanager.ios.ts
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { ContentView } from "tns-core-modules/ui/content-view";
import { TextView } from "tns-core-modules/ui/text-view";
import { ContentView, TextView } from "@nativescript/core";

export class PreviousNextView extends ContentView {
createNativeView() {
Expand Down
13 changes: 8 additions & 5 deletions src/package.json
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "nativescript-iqkeyboardmanager",
"version": "1.5.1",
"version": "1.5.2",
Copy link

@Codex- Codex- Oct 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major compatibility change means this will no longer be compatible with NS6 projects, ideally this means that this should be bumped to 2.0.0.

Copy link
Author

@grey280 grey280 Oct 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, but I'll leave that decision up to @tjvantoll (or you, if you wind up publishing this version instead)

"description": "NativeScript wrapper of the popular IQKeyboardManager iOS library",
"main": "iqkeyboardmanager",
"typings": "index.d.ts",
Expand Down Expand Up @@ -37,17 +37,20 @@
{
"name": "Eddy Verbruggen",
"email": "eddyverbruggen@gmail.com"
},
{
"name": "Grey Patterson",
"email": "greypatterson@gmail.com"
}
],
"homepage": "https://github.com/tjvantoll/nativescript-IQKeyboardManager",
"bugs": {
"url": "https://github.com/tjvantoll/nativescript-IQKeyboardManager/issues"
},
"devDependencies": {
"nativescript-dev-typescript": "~0.10.0",
"tns-core-modules": "~6.2.0",
"tns-platform-declarations": "~6.2.0",
"typescript": "3.4.5",
"@nativescript/core": "~7.0.0",
"@nativescript/types": "~7.0.0",
"typescript": "~3.9.0",
"tslint": "^5.0.0"
}
}
2 changes: 1 addition & 1 deletion src/references.d.ts
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
/// <reference path="./node_modules/tns-platform-declarations/ios/ios.d.ts" />
/// <reference path="./node_modules/@nativescript/types-ios/index.d.ts" />
/// <reference path="./index.d.ts" />
5 changes: 3 additions & 2 deletions src/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
{
"compilerOptions": {
"target": "es5",
"module": "commonjs",
"target": "ES2017",
"module": "esnext",
"moduleResolution": "node",
"declaration": true,
"removeComments": true,
"noLib": false,
Expand Down