fix: ensure consistent hashing for specialized owned and reference types #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that `String` and `&String` compute identical hashes, as well as `OsStr` and `Path`. To resolve this, a recursive macro implements up to five `&&&&&` for each specialized type. `String` types are also included. Previously the tests were passing only because a known type was used (ex. `str::get_hash`). This bypassed the type resolution occurring in generic interfaces, and missed the fact that references `&String` type fallback to the default implementation. This is now verified by testing on the `hash_one` method that lets the compiler infers the type.
Author
|
As a side note, the current implementation is really leaky and leads to hard-to-track-down behaviors. It is virtually impossible to predict every combination of references and types, not even considering user custom types (e.g., MyString(String)) that will fail to integrate seamlessly with the specialization. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that
Stringand&Stringcompute identical hashes, as well asOsStrandPath.To resolve this, a recursive macro implements up to five
&&&&&for each specialized type.Stringtypes are also included.Previously the tests were passing only because a known type was used (ex.
str::get_hash). This bypassed the type resolution occurring in generic interfaces, and missed the fact that references&Stringtype fallback to the default implementation.This is now verified by testing on the
hash_onemethod that lets the compiler infers the type.