Conversation
Co-authored-by: tmorin <1984597+tmorin@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR aims to upgrade the repository’s Java toolchain/baseline to the current LTS (Java 21), covering local developer tooling, CI, and an example module.
Changes:
- Bump root Maven compiler
source/targetfrom 11 → 21. - Update CI build workflow to install JDK 21.
- Update SDKMAN Java version and Quarkus example
maven.compiler.releaseto 21.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| pom.xml | Sets root compiler source/target to 21 for the multi-module build. |
| examples/todo-infra-quarkus/pom.xml | Compiles the Quarkus example with --release 21. |
| .sdkmanrc | Pins local Java to 21.0.10-tem. |
| .github/workflows/ci-build.yaml | Updates CI to use Java 21. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot apply all changes from the pr |
… fix GHA setup Co-authored-by: tmorin <1984597+tmorin@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot check the build which failed |
Co-authored-by: tmorin <1984597+tmorin@users.noreply.github.com>
The build failure was caused by the Sonar analysis step attempting to run without a SONAR_TOKEN (which isn't available for PRs from copilot branches). The actual build with Java 21 succeeded. Fixed in 1c88cdd by making the Sonar analysis step conditional - it now only runs when SONAR_TOKEN is available. The Java 21 upgrade is working correctly. |
|
@copilot in fact remove the sonar integration is over. we can skip the build but the upload of the findings to sonarcloud is not possible any more. |
Co-authored-by: tmorin <1984597+tmorin@users.noreply.github.com>
Removed all Sonar integration in 9faa7b0:
The CI now runs only the build and deployment steps. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.