Open
Conversation
Owner
|
@meabed Thank you so much for the contribution. We will take this PR as a reference when we start v3 development later on. I would prefer keeping I will mention |
Author
|
You are awesome :) make people text sense, thanks 🙏 let me know how can I help if needed. |
Author
|
Awesome, do I need to update my pr? Or how could I help in this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you <3! the literary is incredible!
I have been trying to bundle the library in typescript project and its always throwing an error of implicit type any - because of publishing .ts files in the build, So i have forked it and have done various chores, please have a look if this is something you would want to be merged. Thanks!!!