Open
Conversation
Adds `octetStringBuilder` to libsaml to DRY up the signature alg code. The octet string is needed in four places: creating and verifying the signature for the Redirect and SimpleSign bindings. Previously, both creations were done adhoc while both verifications where not done by the samlify at all and instead left to user code. tngan#308 tngan#360 The new util is now used during verification if the request object does not include a `octetString` key.
mastermatt
force-pushed
the
octet-string
branch
from
49e8361 to
647bce9
Compare
Contributor
Author
|
@tngan I've rebased onto latest, could you take another look? |
|
@tngan Could you please review this. |
# Conflicts: # src/libsaml.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
octetStringBuilderto libsaml to DRY up the signature alg code.The octet string is needed in four places: creating and verifying the signature for the Redirect and SimpleSign bindings. Previously, both creations were done adhoc while both verifications where not done by the samlify at all and instead left to user code. #308 #360
The new util is now used during verification if the request object does not include a
octetStringkey.A note on the tests: a lot of the tests on master don't pass. Before making my changes, I started by getting the tests green by skipping 13 tests and tweaking a further 4. I then made my changes and was content knowing that my changes hadn't broken any of the tests that passed previously.The broken tests seem to focus on encryption due to an upgrade of
xml-cryptoand logout flows due to #501. So I'm not overly concerned, but it is worth noting that someone can't pull this repo and run the tests currently.The tests were fixed before the latest rebase.
@tngan
fixes #308 fixes #360