fix(sqlite): transpile Postgres escaped strings as text literals#7678
Closed
russellromney wants to merge 1 commit into
Closed
fix(sqlite): transpile Postgres escaped strings as text literals#7678russellromney wants to merge 1 commit into
russellromney wants to merge 1 commit into
Conversation
Collaborator
|
@russellromney thanks for the PR. The PR doesn't solve the problem in general right ? it misses cases like |
Collaborator
|
It appears that solving the general case would entail pinning down every possible escaped byte sequence and de-escaping it by emitting the actual character. I'm not sure to what extent this is possible or what the end solution will look like, but it seems too complicated. I'd rather we don't do this right now and call |
Collaborator
|
Closing this for now, but happy to continue discussing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #7677. Postgres
E'...'strings parse asByteString, and SQLite currently has no byte string delimiter, so generation falls back to an unsupported empty string. That drops valid text payloads during Postgres -> SQLite transpilation.This makes the SQLite generator render
ByteStringas a normal quoted text literal, preserving the decoded payload.Examples fixed:
Checks run: