Skip to content

fix(postgres): parse schema-qualified COMMENT ON TYPE, VIEW, SEQUENCE, and INDEX #7684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geooo109 merged 5 commits into from
May 27, 2026
+7 −1
Merged

fix(postgres): parse schema-qualified COMMENT ON TYPE, VIEW, SEQUENCE, and INDEX #7684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
755c51d
fix(postgres): parse schema-qualified COMMENT ON TYPE and VIEW
May 27, 2026
a6d7685
fix(postgres): parse schema-qualified COMMENT ON SEQUENCE
May 27, 2026
e8769e6
fix(postgres): parse schema-qualified COMMENT ON INDEX
May 27, 2026
e8e5054
fix: fallback to _parse_table_parts
May 27, 2026
6d0d863
fix: TABLE route
devfros May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sqlglot/parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2193,7 +2193,7 @@ def _parse_comment(self, allow_exists: bool = True) -> exp.Expr:
elif kind.token_type == TokenType.COLUMN:
this = self._parse_column()
else:
this = self._parse_id_var()
this = self._parse_table_parts(schema=True)

self._match(TokenType.IS)

Expand Down
6 changes: 6 additions & 0 deletions tests/dialects/test_postgres.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,12 @@ def test_postgres(self):
self.validate_identity("SELECT CASE WHEN SUBSTRING('abcdefg') IN ('ab') THEN 1 ELSE 0 END")
self.validate_identity("COMMENT ON TABLE mytable IS 'this'")
self.validate_identity("COMMENT ON MATERIALIZED VIEW my_view IS 'this'")
self.validate_identity("COMMENT ON TYPE mood IS 'x'")
self.validate_identity("COMMENT ON TYPE foo.mood IS 'x'")
self.validate_identity("COMMENT ON VIEW foo.bat IS 'x'")
self.validate_identity("COMMENT ON MATERIALIZED VIEW foo.my_view IS 'x'")
self.validate_identity("COMMENT ON SEQUENCE public.seq IS 'x'")
self.validate_identity("COMMENT ON INDEX public.idx IS 'x'")
self.validate_identity("SELECT e'\\xDEADBEEF'")
self.validate_identity("SELECT CAST(e'\\176' AS BYTEA)")
self.validate_identity("SELECT * FROM x WHERE SUBSTRING('Thomas' FROM '...$') IN ('mas')")
Expand Down
Loading