Updates, New APIs and Active Model#1
Open
danielmorrison wants to merge 21 commits intotogethr:masterfrom
Open
Conversation
We have rubocop, so let's fix what it recommends.
Adds string literal comments
By default it was erroring on new fields. That's a bit aggressive, so just warn instead.
Otherwise it always defaults to false. Not really needed, but adding for correctness
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This started as wanting to pull from more APIs (pages, which was completed in another fork, authors, and tags).
Then I began an Active Model rewrite. I'm not married to that idea, but it worked well for my purposes. I was able to do it without changing any functionality.
Pages mirrors Posts. Authors and Tags are pretty similar. Tests added for new stuff.