sf-upgrade + github actions

.env

@@ -9,6 +9,7 @@
 # Real environment variables win over .env files.
 #
 # DO NOT DEFINE PRODUCTION SECRETS IN THIS FILE NOR IN ANY OTHER COMMITTED FILES.
+# https://symfony.com/doc/current/configuration/secrets.html
 #
 # Run "composer dump-env prod" to compile .env files for production use (requires symfony/flex >=1.2).
 # https://symfony.com/doc/current/best_practices.html#use-environment-variables-for-infrastructure-configuration
@@ -18,20 +19,11 @@
 # IMPORTANT: You MUST configure your server version, either here or in config/packages/doctrine.yaml
 #
 # DATABASE_URL="sqlite:///%kernel.project_dir%/var/data.db"
-DATABASE_URL="mysql://mental_note:SOME_SECRET@127.0.0.1:3306/mental_note?serverVersion=5.7"
+DATABASE_URL="mysql://root:test@db:3306/mental_note?serverVersion=8.0"
 #DATABASE_URL="postgresql://db_user:db_password@127.0.0.1:5432/db_name?serverVersion=13&charset=utf8"
 ###< doctrine/doctrine-bundle ###
-
-###> symfony/swiftmailer-bundle ###
-# For Gmail as a transport, use: "gmail://username:password@localhost"
-# For a generic SMTP server, use: "smtp://localhost:25?encryption=&auth_mode="
-# Delivery is disabled by default via "null://localhost"
-MAILER_URL=null://localhost
-###< symfony/swiftmailer-bundle ###
-
 ###> symfony/framework-bundle ###
 APP_ENV=dev
 APP_SECRET=5c5e72737c8468479c674ad5ff7f0dd7
-#TRUSTED_PROXIES=127.0.0.0/8,10.0.0.0/8,172.16.0.0/12,192.168.0.0/16
-#TRUSTED_HOSTS='^(localhost|example\.com)$'
 ###< symfony/framework-bundle ###
+MEMCACHED_HOST=memcached

.env.test

@@ -1,7 +1,7 @@
 # define your env variables for the test env here
-KERNEL_CLASS='AppBundle\Kernel'
+KERNEL_CLASS='App\Kernel'
 APP_SECRET='$ecretf0rt3st'
 SYMFONY_DEPRECATIONS_HELPER=999999
 PANTHER_APP_ENV=panther
 PANTHER_ERROR_SCREENSHOT_DIR=./var/error-screenshots
-DATABASE_URL="sqlite:///%kernel.project_dir%/var/test-database.db"
+DATABASE_URL="mysql://mental_note:SOME_SECRET@127.0.0.1:3306/mental_note_tests?serverVersion=5.7"

.github/workflows/phpunit.yml

@@ -12,11 +12,24 @@ jobs:
         runs-on: "ubuntu-latest"
 
         strategy:
+            fail-fast: false
             matrix:
                 php-version:
                     - "7.4"
                     - "8.0"
 
+        services:
+          mysql:
+            image: mysql:5.7
+            env:
+              MYSQL_ALLOW_EMPTY_PASSWORD: yes
+              MYSQL_DATABASE: mental_note_tests
+              MYSQL_USER: mental_note
+              MYSQL_PASSWORD: SOME_SECRET
+            ports:
+              - 3306:3306
+            options: --health-cmd "mysqladmin ping --silent"
+
         steps:
             - name: "Checkout"
               uses: actions/checkout@v3
@@ -32,4 +45,8 @@ jobs:
             - uses: ramsey/composer-install@2.1.0
 
             - name: "Tests"
-              run: "./run-tests --coverage-clover=clover.xml --coverage-text"
+              run: "./run-tests --coverage-text=coverage.txt"
+
+            - name: "Coverage Output"
+              if: "${{ always() }}"
+              run: cat coverage.txt >> $GITHUB_STEP_SUMMARY

.gitignore

@@ -11,22 +11,22 @@
 /var/sessions/*
 /bin/*
 
-/web/thumbnails/*
-/web/bundles/*
-/web/css/*
-/web/js/*
-/web/fonts/*
+/public/thumbnails/*
+/public/bundles/*
+/public/css/*
+/public/js/*
+/public/fonts/*
 .php_cs.cache
 
 !var/SymfonyRequirements.php
 !var/logs/.gitkeep
 !/var/sessions
 !var/cache/.gitkeep
 !var/sessions/.gitkeep
-!/web/thumbnails/.gitkeep
-!/web/bundles/.gitkeep
-!/web/css/.gitkeep
-!/web/js/.gitkeep
+!/public/thumbnails/.gitkeep
+!/public/bundles/.gitkeep
+!/public/css/.gitkeep
+!/public/js/.gitkeep
 !/bin/console
 
 ###> phpunit/phpunit ###
@@ -43,3 +43,12 @@
 /var/
 /vendor/
 ###< symfony/framework-bundle ###
+
+###> squizlabs/php_codesniffer ###
+/.phpcs-cache
+/phpcs.xml
+###< squizlabs/php_codesniffer ###
+
+###> phpstan/phpstan ###
+phpstan.neon
+###< phpstan/phpstan ###

.phpactor.json

@@ -0,0 +1,12 @@
+{
+    "$schema": "/phpactor.schema.json",
+    "symfony.enabled": true,
+    "indexer.exclude_patterns": [
+        "/vendor/**/Tests/**/*",
+        "/vendor/**/tests/**/*",
+        "/var/cache/**/*",
+        "/vendor/composer/**/*"
+    ],
+    "php_code_sniffer.enabled": true,
+    "language_server_phpstan.enabled": true
+}

Makefile

@@ -0,0 +1,15 @@
+vendor: composer.json composer.lock
+	composer install
+
+dev: vendor
+	symfony local:server:start -d
+	#symfony run -d yarn encore dev --watch
+	symfony server:log
+
+dev-stop:
+	symfony local:server:stop
+
+prod: vendor
+	sudo chown -R www-data:www-data var
+	sudo -u www-data bin/console ca:cl --env=prod
+	#sudo -u www-data