Skip to content

Fix conflicting Redis updates implementation (#625)#626

Open
ikavalio wants to merge 1 commit intotoluaina:mainfrom
ikavalio:ikavalio/redis-correct-partial-updates
Open

Fix conflicting Redis updates implementation (#625)#626
ikavalio wants to merge 1 commit intotoluaina:mainfrom
ikavalio:ikavalio/redis-correct-partial-updates

Conversation

@ikavalio
Copy link
Copy Markdown

I've tried to fix #625 naively by storing metadata in redis as a hash rather than serialized JSON object (also added scalar implementation path since set_meta / get_meta interface accepts t.Any). Both old format (scalar) and hash are supported for backwards compatibility, but data is always written in the new format.

I tested it locally and new key format seems to be correct:

127.0.0.1:6379> hgetall "queue:db_table:meta"
1) "checkpoint"
2) "80340"
3) "txid_current"
4) "80346"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

status thread overwrites checkpoint information when REDIS_CHECKPOINT is enabled

1 participant