Fix broken stock bridge promises and packaging logic#27
Open
dudebehinddude wants to merge 4 commits intotom5454:mainfrom
Open
Fix broken stock bridge promises and packaging logic#27dudebehinddude wants to merge 4 commits intotom5454:mainfrom
dudebehinddude wants to merge 4 commits intotom5454:mainfrom
Conversation
|
Any way you'd consider back-porting this to the 1.20 branch? Might make it easier for someone to pick up a fork. This project really needs some attention, seems like the maintainer has kind of abandoned it. |
Author
|
@adam8797 From the 5 minutes of looking at the changes since 1.20 it's hard to say how easy this is to backport (but it looks like it's at least probably not trivial), but you could probably copy paste the diff into claude code or codex or something and it'd be able to do it..? But I don't really have the time to maintain something like this as I am pretty busy with college :P |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have been using this mod in a server I am running, but I ran into some issues that made it basically impossible for me to actually use it as intended in my base, so I decided to fix them and open a PR. Mainly, this should address:
I have my formatter setup to run on save and some of the code changes are probably slightly poorly thought out (mainly dealing with package combining), so if you want to close this and copy some of the code changes yourself or modify this PR I don't mind (I just wanted this to be fixed on my server, and I thought I would contribute the changes in case they're useful).
Fixes #14
Fixes #18
Fixes #22