Fix an issue with parking_lot >= 0.8.1#13
Open
dodomorandi wants to merge 1 commit intotomaka:masterfrom
Open
Conversation
neacsu
added a commit
to nymtech/nym
that referenced
this pull request
Aug 12, 2021
... which addresses the problem from Amanieu/parking_lot#269 by taking the unmerged workaround of tomaka/wasm-timer#13 , as wasm-timer appears to be unmaintained.
jstuczyn
pushed a commit
to nymtech/nym
that referenced
this pull request
Aug 13, 2021
... which addresses the problem from Amanieu/parking_lot#269 by taking the unmerged workaround of tomaka/wasm-timer#13 , as wasm-timer appears to be unmaintained.
|
Is this repository stoped maintaining? why maintainer don't merge this..? |
|
@tomaka Would it be possible to merge this and make a release? It seems simple enough and without it people have to work around it, either using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an issue with
parking_lot >= 0.8.1, because the previously dummyInstanthas been replaced with the one from theinstantcrate. Unfortunately, when neither thewasm-bindgenorwebstdfeatures are passed toinstant, it exposes anextern "C" nowfunction, which will create problem when linking/loading modules.This fix is trivial and should not be breaking (right?).