Skip to content

Comments

fix: Breaking changes in new dulwich version#175

Merged
tomasfarias merged 6 commits intotomasfarias:masterfrom
stecalde:fix-dulwich-dependency
Feb 16, 2026
Merged

fix: Breaking changes in new dulwich version#175
tomasfarias merged 6 commits intotomasfarias:masterfrom
stecalde:fix-dulwich-dependency

Conversation

@stecalde
Copy link
Contributor

Uploading project to git repository fails with AttributeError, this PR introduces compatibility with latest dulwich version 1.0.0

Copy link
Owner

@tomasfarias tomasfarias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this fix!

I'll wait for CI to run, and if all tests are passing then I'll merge this. If maintaining backwards compatibility becomes a bigger issue, I'd be completely fine to just require dulwich>=1.0.0.

EDIT: Other errors popped up, so I went with just requiring dulwich>=1.0.0.

@tomasfarias tomasfarias changed the title Fix bug related to breaking changes in new dulwich version fix: Breaking changes in new dulwich version Feb 16, 2026
@tomasfarias
Copy link
Owner

I'll do some minor changes for the linters to pass.

@tomasfarias tomasfarias linked an issue Feb 16, 2026 that may be closed by this pull request
@tomasfarias tomasfarias reopened this Feb 16, 2026
@tomasfarias
Copy link
Owner

Sorry, accidentally closed the PR.

Looks like the issue extends a bit further than stage as do_commit is also deprecated in 1.0.0.

@tomasfarias
Copy link
Owner

Okay, tests are passing locally. I think this should be good to go.

@tomasfarias tomasfarias merged commit 63b6894 into tomasfarias:master Feb 16, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] AttributeError on newer dulwich versions

2 participants