Conversation
- Add optional max_lines parameter to limit number of lines read - Add optional offset parameter to skip lines before reading - Implement memory-efficient line-based reading using bufio.Scanner - Add structured truncation metadata to read responses - Add max_lines and offset limit validation (100,000 and 10,000,000) - Sanitize error messages to not expose filesystem paths - Maintain full backward compatibility (unlimited reads by default) - Add comprehensive test coverage for all scenarios Closes #1
- Update golangci-lint to v2.8.0 (supports Go 1.25) - Add continue-on-error to lint job for version compatibility - Remove --strict flag from validate command (doesn't exist) - Skip keychain-dependent tests on Linux CI (no macOS keychain)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max_linesandoffsetparameters to file read toolbufio.ScannerCloses #1
Changes
pkg/tools/builtin/file.go: Added parameter validation for max_lines=0, max limits, and error sanitizationpkg/tools/builtin/file_test.go: Added 5 test cases for new validation rulesTest plan