Conversation
Implement a two-tier E2E testing strategy to ensure workflow execution quality: - MockLLMProvider: Implements llm.Provider interface for deterministic testing without external LLM dependencies - Test harness: Provides assertion helpers (AssertWorkflowOutput, AssertToolExecution, AssertStepExecution) for flexible workflow validation - 25 mock E2E tests: Cover workflow execution, step sequencing, conditional logic, error handling, and tool integration - 10 smoke tests: Verify real integration with Ollama (free, local-first approach) and Anthropic APIs - 5 YAML workflow fixtures: Sample workflows for testing various executor capabilities New Makefile targets enable easy test execution: - test-e2e: Run all mock-based E2E tests - test-smoke: Run integration smoke tests with real LLM providers Updates to testing infrastructure: - Extended testing/integration/config to support mock provider setup - Added LLMProvider options to SDK for test configuration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement a two-tier E2E testing strategy with mock-based tests and smoke tests to ensure workflow execution quality and validate executor functionality.
test-e2eandtest-smokefor easy test executionKey Components
Mock E2E Tests
Smoke Tests
Testing Infrastructure
test/e2e/harness: Core testing framework with MockLLMProvider, test harness, assertionstest/e2e/testdata: YAML workflow fixturestesting/integration/configfor mock provider setupTest Plan
make test-e2e,make test-smoke)