Feature/deploying 1.5.0#357
Merged
Merged
Conversation
The native engine builds via setup.py (used by pip install and cibuildwheel), so build_fjcore.py was only a convenience wrapper for in-place dev builds + the MSVC PGO passes. With measurement/PGO no longer needed, drop it and point the docs at `pip install -e .` (the non-deprecated in-place build). References updated: README.md, flipjump/README.md, flipjump/interpreter/fjm_run.py docstring, setup.py's skip-warning, and benchmark_results.md (build line + the historical v6 PGO row re-labeled "build path since removed"). setup.py needed no change beyond its warning text - it already declares the _fjcore Extension. Verified: `python setup.py build_ext --inplace --force` builds the engine, it loads as native-active, and all 37 native-engine unit tests pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Remove the opt-in FLIPJUMP_MEASURE_SPECULATION study feature (study/measurement code, not shipped functionality): - _fjcore.c: delete the SpecShadow tables, spec_record, the 111-line run_measured_loop, the Memory_run dispatch, the struct fields/init, and the speculation_stats getter (-223 lines). The real run-loops are untouched, so every op-count is identical (verified by tests/wheel_smoke.py). - fjm_run.py / utils/classes.py: drop the speculation_stats plumbing (and the now-unused Dict import). - test_native_memory.py: drop the 2 speculation tests (cpu_calibrate tests stay - cpu_calibrate is the wheel_smoke release yardstick). - tests/benchmarks/measure_speculation.py: deleted. - benchmark_results.md: keep the speculation/oracle design-record, drop its references to the removed measure_speculation.py + FLIPJUMP_MEASURE_SPECULATION. Docs: - README.md: list interpreter/_fjcore.c in the Project Structure (native engine). - flipjump/README.md: sync the native-engine speed figure (~300M fj-ops/s) with README.md's interpreter section. Verified: setup.py builds the engine, native active, all op-counts exact (wheel_smoke), full unit suite green (408 passed), black/flake8/mypy clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.