feat(Groth16): add working examples of Groth16 verification#1964
Draft
delovoyhomie wants to merge 1 commit intomainfrom
Draft
feat(Groth16): add working examples of Groth16 verification#1964delovoyhomie wants to merge 1 commit intomainfrom
delovoyhomie wants to merge 1 commit intomainfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+1
to
+6
| --- | ||
| title: "Verify Groth16 examples on TON" | ||
| sidebarTitle: "Groth16 examples" | ||
| description: "Run Groth16 verifier examples on TON with Circom, Noname, Gnark, and Arkworks." | ||
| doc_type: "How-to guide" | ||
| --- |
Contributor
There was a problem hiding this comment.
[HIGH] Unsupported doc_type frontmatter key
Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone!
Comment on lines
+1
to
+4
| --- | ||
| title: "Verify Groth16 examples on TON" | ||
| sidebarTitle: "Groth16 examples" | ||
| description: "Run Groth16 verifier examples on TON with Circom, Noname, Gnark, and Arkworks." |
Contributor
There was a problem hiding this comment.
[HIGH] How‑to page title does not follow “How to X” pattern
Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone!
Comment on lines
+54
to
+67
| ```bash | ||
| cd circuits/Multiplier | ||
| circom Multiplier.circom --r1cs --wasm --sym --prime bls12381 | ||
| snarkjs powersoftau new bls12-381 10 pot10_0000.ptau -v | ||
| snarkjs powersoftau contribute pot10_0000.ptau pot10_0001.ptau --name="First contribution" -v -e="some random text" | ||
| snarkjs powersoftau prepare phase2 pot10_0001.ptau pot10_final.ptau -v | ||
| snarkjs groth16 setup Multiplier.r1cs pot10_final.ptau Multiplier_0000.zkey | ||
| snarkjs zkey contribute Multiplier_0000.zkey Multiplier_final.zkey --name="1st Contributor" -v -e="some random text" | ||
| snarkjs zkey export verificationkey Multiplier_final.zkey verification_key.json | ||
| cd ../.. | ||
| npx export-ton-verifier ./circuits/Multiplier/Multiplier_final.zkey ./contracts/verifier_multiplier.tact --tact | ||
| npx blueprint build --all | ||
| npx blueprint test Verifier_multiplier_tact | ||
| ``` |
Contributor
There was a problem hiding this comment.
[HIGH] Unsafe mainnet‑adjacent commands lack explicit safety callout
Suggested change
| ```bash | |
| cd circuits/Multiplier | |
| circom Multiplier.circom --r1cs --wasm --sym --prime bls12381 | |
| snarkjs powersoftau new bls12-381 10 pot10_0000.ptau -v | |
| snarkjs powersoftau contribute pot10_0000.ptau pot10_0001.ptau --name="First contribution" -v -e="some random text" | |
| snarkjs powersoftau prepare phase2 pot10_0001.ptau pot10_final.ptau -v | |
| snarkjs groth16 setup Multiplier.r1cs pot10_final.ptau Multiplier_0000.zkey | |
| snarkjs zkey contribute Multiplier_0000.zkey Multiplier_final.zkey --name="1st Contributor" -v -e="some random text" | |
| snarkjs zkey export verificationkey Multiplier_final.zkey verification_key.json | |
| cd ../.. | |
| npx export-ton-verifier ./circuits/Multiplier/Multiplier_final.zkey ./contracts/verifier_multiplier.tact --tact | |
| npx blueprint build --all | |
| npx blueprint test Verifier_multiplier_tact | |
| ``` |
Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone!
Comment on lines
+156
to
+180
| ## Verify | ||
|
|
||
| Run-time verification succeeds when all of the following are true: | ||
|
|
||
| - `snarkjs.groth16.verify(...)` returns `true` | ||
| - The contract `getVerify` method returns `true` | ||
| - `npx blueprint test ...` exits with code `0` | ||
|
|
||
| Partial snippet from the upstream Tact tests. Not runnable: | ||
|
|
||
| ```ts | ||
| const okLocal = await snarkjs.groth16.verify(verificationKey, publicSignals, proof); | ||
| expect(okLocal).toBe(true); | ||
|
|
||
| const { pi_a, pi_b, pi_c, pubInputs } = await groth16CompressProof(proof, publicSignals); | ||
|
|
||
| expect( | ||
| await verifier.getVerify( | ||
| beginCell().storeBuffer(pi_a).endCell().asSlice(), | ||
| beginCell().storeBuffer(pi_b).endCell().asSlice(), | ||
| beginCell().storeBuffer(pi_c).endCell().asSlice(), | ||
| dictFromInputList(pubInputs), | ||
| ), | ||
| ).toBe(true); | ||
| ``` |
Contributor
There was a problem hiding this comment.
[HIGH] Missing “Not runnable” label on partial snippet
Suggested change
| ## Verify | |
| Run-time verification succeeds when all of the following are true: | |
| - `snarkjs.groth16.verify(...)` returns `true` | |
| - The contract `getVerify` method returns `true` | |
| - `npx blueprint test ...` exits with code `0` | |
| Partial snippet from the upstream Tact tests. Not runnable: | |
| ```ts | |
| const okLocal = await snarkjs.groth16.verify(verificationKey, publicSignals, proof); | |
| expect(okLocal).toBe(true); | |
| const { pi_a, pi_b, pi_c, pubInputs } = await groth16CompressProof(proof, publicSignals); | |
| expect( | |
| await verifier.getVerify( | |
| beginCell().storeBuffer(pi_a).endCell().asSlice(), | |
| beginCell().storeBuffer(pi_b).endCell().asSlice(), | |
| beginCell().storeBuffer(pi_c).endCell().asSlice(), | |
| dictFromInputList(pubInputs), | |
| ), | |
| ).toBe(true); | |
| ``` |
Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone!
Comment on lines
+468
to
+473
| { | ||
| "group": "Privacy & ZK", | ||
| "pages": [ | ||
| "contract-dev/zero-knowledge", | ||
| "contract-dev/privacy-zk/groth16-examples" | ||
| ] |
Contributor
There was a problem hiding this comment.
[HIGH] Sidebar group label uses nonstandard casing and ampersand
Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone!
Collaborator
There was a problem hiding this comment.
I'd just replace "Privacy & ZK" with "ZK-proofs" or somesuch
novusnota
reviewed
Mar 18, 2026
|
|
||
| | Example | Stack | Circuit | What the proof exposes publicly | Tact test | | ||
| | ------------- | -------- | ----------------------------------------------------------------------------------------------------------------------- | ------------------------------- | --------------------------------------------- | | ||
| | `Multiplier` | Circom | [`circuits/Multiplier`](https://github.com/zk-examples/zk-ton-examples/tree/main/circuits/Multiplier) | `c = a * b` | `npx blueprint test Verifier_multiplier_tact` | |
Collaborator
There was a problem hiding this comment.
tact
Here and below, let's only use and reference Tolk examples.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1840