Make core modules TorchScript compatible#168
Open
MarcelloCeresini wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates
exportPythonModelso that the generatedTracerModelclasses can be scripted withtorch.jit.script.What Changed
nnodely/exporter/export.pyDictandTupleTracerModel.forwardnow has a TorchScript compatible type signaturetorch.jit.annotate(Dict[str, torch.Tensor], ...)so their types are visible and constant for TorchScriptupdatenow uses safe non-mutable defaultsNoneinstead of{}, and is also marked withtorch.jit.ignoresince it's not needed for inferencetests/test_export_native_torchscript.pyexportPythonModeltorch.jit.script(TracerModel())Why
TorchScript exports make nnodely models easier to deploy outside Python, in particular they can be loaded from C++ applications through LibTorch, enabling integration into simulators or embedded systems with a small change to the generated export code.