Skip to content

adding advanced features#18

Merged
sajeerzeji merged 3 commits into
toolpack-ai:mainfrom
venmanyarun:advanced_features
Apr 9, 2026
Merged

adding advanced features#18
sajeerzeji merged 3 commits into
toolpack-ai:mainfrom
venmanyarun:advanced_features

Conversation

@venmanyarun
Copy link
Copy Markdown
Contributor

Description

Advanced Knowledge Features

  • Web URL sources (crawl and index websites)
  • API data sources (index REST APIs)
  • Streaming ingestion for large datasets
  • Hybrid search (combining semantic and keyword search)

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Explain how to reproduce the testing environment.

  • [ x] npm run test
  • Specific tool test (e.g., npm run test:tools:fs)
  • Manual testing (describe below)

Checklist:

  • [x ] My code follows the style guidelines of this project
  • [ x] I have performed a self-review of my own code
  • [x ] I have commented my code, particularly in hard-to-understand areas
  • [x ] I have made corresponding changes to the documentation
  • [x ] My changes generate no new warnings (run npm run lint)
  • [x ] I have added tests that prove my fix is effective or that my feature works
  • [x ] New and existing unit tests pass locally with my changes

@sajeerzeji
Copy link
Copy Markdown
Contributor

I have tested this and found few areas of improvements. Adding AI review comments as well.

Comment thread packages/toolpack-knowledge/src/knowledge.ts
Comment thread packages/toolpack-knowledge/src/knowledge.ts Outdated
Comment thread packages/toolpack-knowledge/src/__tests__/api-source.test.ts Outdated
Comment thread packages/toolpack-knowledge/src/sources/web-url.ts
@venmanyarun venmanyarun requested a review from sajeerzeji April 9, 2026 07:30
@sajeerzeji sajeerzeji merged commit 1aea1c7 into toolpack-ai:main Apr 9, 2026
6 checks passed
@sajeerzeji sajeerzeji added the enhancement New feature or request label Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants