Fix setup-uv cache dependency config in lint and test workflows#53
Open
smortezah wants to merge 5 commits intotoon-format:mainfrom
Open
Fix setup-uv cache dependency config in lint and test workflows#53smortezah wants to merge 5 commits intotoon-format:mainfrom
smortezah wants to merge 5 commits intotoon-format:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds cache-dependency-glob: pyproject.toml to setup-uv in both the lint and test workflows so the uv cache key is based on pyproject.toml instead of missing default files. Also adds a Copilot PR description template.
Changes:
- Add
cache-dependency-glob: pyproject.tomltosetup-uvinlint.ymlandtest.yml - Add
.copilot-pull-request-description-instructions.mdPR template
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/lint.yml |
Add cache dependency glob for uv |
.github/workflows/test.yml |
Add cache dependency glob for uv |
.copilot-pull-request-description-instructions.md |
New PR description template for Copilot |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| uses: astral-sh/setup-uv@v7 | ||
| with: | ||
| enable-cache: true | ||
| cache-dependency-glob: pyproject.toml |
alesanfra
requested changes
Mar 17, 2026
alesanfra
left a comment
There was a problem hiding this comment.
It looks like pyproject.toml is already in the default dependency files according to the doc, am I missing something?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Configure
astral-sh/setup-uvcache invalidation explicitly in the lint workflow.Changes
enable-cache: truecache-dependency-glob: pyproject.tomlWhy
The workflow enables uv caching, but the repository does not appear to contain the default dependency files used by
setup-uvfor cache keys (uv.lockorrequirements*.txt). Pointing cache invalidation atpyproject.tomlavoids the warning and keeps caching enabled.