Open
Conversation
- Remove non-existent CSS import from landing.ts - Update build script to use simple vite build - Add PluginConfig export to module federation - Update Gun.js to use configurable peers instead of hardcoded localhost - Fix plugin URL in commented code 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Updates main.ts to calculate baseUrl dynamically, matching the pattern used in link-plugin and other plugins. This ensures the plugin URL works correctly in both development and production environments. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Update @toplocs/plugin-sdk to use published version ^1.1.0 instead of GitHub - Restore CSS import in landing.ts (now it will work with published SDK) - This matches the setup used in link-plugin and other working plugins 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Split build and deploy into separate jobs for better error handling - Add pnpm caching for faster builds - Use pnpm version 8 (matching link-plugin) - Add better comments and structure - This matches the proven workflow from link-plugin 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Comment out PluginInfoPage import and usage to avoid module federation errors - Add @toplocs/plugin-sdk to rollupOptions.external - Add optimizeDeps exclude for plugin SDK - Keep CSS import commented until SDK build issues are resolved The plugin SDK has issues with its module federation build that prevent it from being used during the build process. This is a temporary fix to get the location-plugin deploying. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Remove @toplocs/plugin-sdk from external dependencies - Re-enable CSS import and PluginInfoPage component - Fix plugin URL endpoint to not use /assets path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes all deployment issues preventing location-plugin from building and deploying to GitHub Pages.
Changes Made
1. Build Configuration
vite buildprocessassetsDir: ''to match other plugins.nojekyllfile creation for GitHub Pages2. Module Federation
PluginConfigexport to vite config3. Dynamic URLs
baseUrlinstead of hardcoded localhost4. GitHub Actions
5. SDK Issues (Temporary Fix)
Problem
The plugin SDK has build issues when imported during the build process:
Solution
Temporarily disabled SDK components to get the plugin deploying. The SDK issues need to be addressed separately.
Test Results
pnpm buildNext Steps
🤖 Generated with Claude Code