Closed
Conversation
Contributor
Author
|
We got overriting the extends and includes tags working, so I think this is ready for review! |
Member
|
Omg! Thank you @gone, I’ll find some time to review this properly. |
Contributor
Author
|
Cool yeah, happy to make any changes! |
Contributor
|
@gone I opened a PR to your branch fixing some issues, but I could also open a new one directly here if it's easier for @thibaudcolas to review the entire thing at once. Let me know what you folks prefer. |
Contributor
Contributor
|
Hey @gone 👋🏼 I've opened up a PR to your repo here: gone#6 @thibaudcolas If it's easier, I can open it up directly on the Torchbox upstream. Please let me know what you folks would prefer. Many thanks! 🙌🏼 |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a first pass at jinja support.
Right now this supports the major features I can account for, outside of overriding extends and includes tags.
I haven't really checked against the styleguide/updated documentation/tests so I think this is just in wip status
Fixes # (issue) #171
Checklist