Mark trait U16UtfExt as unsafe as an incorrect implementation could lead to undefined behaviour.#15
Open
bmoxb wants to merge 1 commit intotormol:masterfrom
Open
Mark trait U16UtfExt as unsafe as an incorrect implementation could lead to undefined behaviour.#15bmoxb wants to merge 1 commit intotormol:masterfrom
U16UtfExt as unsafe as an incorrect implementation could lead to undefined behaviour.#15bmoxb wants to merge 1 commit intotormol:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are parts of the code that depend on the implementation of
U16UtfExtbeing correct in order to avoid undefined behaviour. Examples:encode_unicode/src/decoding_iterators.rs
Line 380 in b764bc1
encode_unicode/src/decoding_iterators.rs
Line 383 in b764bc1
These call sites of the trait's methods do not defend against its implementation being incorrect. We therefore think it would be a good idea to mark the trait as unsafe to make it clear that the overall safety of the crate depends on it.