Skip to content

iostream: downgrade the SSL handshake-error log to INFO #3676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HrachShah wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −4
Open

iostream: downgrade the SSL handshake-error log to INFO #3676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tornado/iostream.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1366,7 +1366,7 @@ def _do_ssl_handshake(self) -> None:
peer = self.socket.getpeername()
except Exception:
peer = "(not connected)"
gen_log.warning(
gen_log.info(
"SSL Error on %s %s: %s", self.socket.fileno(), peer, err
)
return self.close(exc_info=err)
Expand Down
6 changes: 3 additions & 3 deletions tornado/test/iostream_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1066,7 +1066,7 @@ def test_start_tls_smtp(self):
def test_handshake_fail(self):
server_future = self.server_start_tls(_server_ssl_options())
# Certificates are verified with the default configuration.
with ExpectLog(gen_log, "SSL Error"):
with ExpectLog(gen_log, "SSL Error", level=logging.INFO):
client_future = self.client_start_tls(server_hostname="localhost")
with self.assertRaises(ssl.SSLError):
yield client_future
Expand All @@ -1077,7 +1077,7 @@ def test_handshake_fail(self):
def test_check_hostname(self):
# Test that server_hostname parameter to start_tls is being used.
server_future = self.server_start_tls(_server_ssl_options())
with ExpectLog(gen_log, "SSL Error"):
with ExpectLog(gen_log, "SSL Error", level=logging.INFO):
client_future = self.client_start_tls(
ssl.create_default_context(), server_hostname="127.0.0.1"
)
Expand Down Expand Up @@ -1231,7 +1231,7 @@ async def test_no_match(self):
with ExpectLog(
gen_log,
".*alert bad certificate",
level=logging.WARNING,
level=logging.INFO,
required=platform.system() != "Windows",
):
with self.assertRaises(ssl.SSLCertVerificationError):
Expand Down