Skip to content

concurrent: format the run_on_executor bad-args ValueError message #3680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
HrachShah wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −1
Draft

concurrent: format the run_on_executor bad-args ValueError message #3680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tornado/concurrent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ def wrapper(self: Any, *args: Any, **kwargs: Any) -> Future:
if len(args) == 1:
return run_on_executor_decorator(args[0])
elif len(args) != 0:
raise ValueError("expected 1 argument, got %d", len(args))
raise ValueError("expected 1 argument, got %d" % len(args))
return run_on_executor_decorator


Expand Down
10 changes: 10 additions & 0 deletions tornado/test/concurrent_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,5 +227,15 @@ async def f():
self.assertEqual(result, 42)


class RunOnExecutorArgValidationTest(AsyncTestCase):
def test_run_on_executor_bad_args(self):
with self.assertRaisesRegex(ValueError, "expected 1 argument, got 2"):
@run_on_executor(1, 2)
def f():
pass

pass


if __name__ == "__main__":
unittest.main()