Local apps shouldn't time out in terms of running#131
Merged
Conversation
jo-sm
reviewed
Nov 17, 2025
Comment on lines
+586
to
+588
| err_count += 1; | ||
|
|
||
| // If we get five errors in a row, we abandon monitoring. |
Member
There was a problem hiding this comment.
I don't see that we reset err_count anywhere, should we reset it if we get a non error?
Contributor
Author
There was a problem hiding this comment.
Sorted--thanks. I accidentally deleted it from an earlier iteration 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the timeout logic slightly for local apps to prevent them from "timing out" after some amount of time. They should be able to run for as long as they need to run!
I also changed the output logic to defer printing the success or error message strictly at the end of the run output.