Add --no-browser to Login to skip opening browsers at login#183
Merged
Add --no-browser to Login to skip opening browsers at login#183
--no-browser to Login to skip opening browsers at login#183Conversation
…nments where our CLI is tricked
bradhe
requested review from
Copilot,
giray123,
jo-sm,
konstantinoscs,
sammuti and
socksy
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a --no-browser flag to the login command to skip automatic browser opening during authentication. This is useful in environments where browser detection is unreliable or where opening a browser is not possible.
Changes:
- Added a
--no-browserCLI flag with short alias-nto the login command - Updated
do_loginandhandle_device_loginfunctions to accept and respect the browser preference - Refactored browser opening logic to conditionally open browser based on the flag
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/tower-cmd/src/session.rs | Adds --no-browser argument definition and updates login flow to conditionally open browser |
| crates/tower-cmd/src/lib.rs | Passes argument matches to do_login function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
socksy
reviewed
Jan 25, 2026
| .arg( | ||
| Arg::new("no-browser") | ||
| .long("no-browser") | ||
| .short('n') |
Contributor
Author
There was a problem hiding this comment.
Open to a better idea
socksy
approved these changes
Jan 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes we can't figure out if the user is able to open a browser or not, and we think we opened one when we didn't. Or, we just know that you can't open a browser in a certain context. Thus, this option let's us just blindly skip all that.