Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements logging improvements across several crates, adding structured telemetry context to subprocess operations and fixing minor code style issues.
Changes:
- Added telemetry context parameter and comprehensive logging throughout the subprocess package handling flow
- Fixed missing semicolon and applied code formatting improvements in tower-uv
- Applied code formatting cleanup in tower-cmd
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/tower-uv/src/lib.rs | Added missing semicolon and reformatted multi-line code for consistency |
| crates/tower-runtime/src/subprocess.rs | Added telemetry context parameter and comprehensive debug/info/error logging throughout package receive and unpack operations |
| crates/tower-cmd/src/util/apps.rs | Reformatted error return statement to single line |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sammuti
requested review from
Copilot,
giray123,
jo-sm,
konstantinoscs and
socksy
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Err(e) => { | ||
| debug!("Failed to open lock file {:?}: {:?}", path, e); | ||
| continue | ||
| continue; |
There was a problem hiding this comment.
Curious how this compiled before...
There was a problem hiding this comment.
Its not a problem here since the type gets coerced to File, so it was just a problem in terms of clarity
3 participants
No description provided.