chore: add timeout for log following of an unresponsive run#197
chore: add timeout for log following of an unresponsive run#197
Conversation
📝 WalkthroughWalkthroughThe changes introduce a 30-second timeout mechanism for waiting for a run to start across multiple modules. When the timeout expires, the system either logs an error and aborts the wait or returns a new RunStartTimeout error variant, replacing unbounded polling with bounded, time-limited waiting. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 🧹 Recent nitpick comments
Comment |
This kept hanging when running the tests with a broken runner, and IMO timing out with an explicit error is better than hanging forever.
Summary by CodeRabbit