-
Notifications
You must be signed in to change notification settings - Fork 3
Add packaging functions to Tower SDK #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
386faba
Add a wraper function to Tower SDK for packaging code for Tower
bradhe 92e4211
Add tests for this exposed functionality
bradhe 12a9189
Add the Tower CLI binary back in the mix
bradhe 26d2daf
Upgrade Maturin usage to find interpreters for us
bradhe a938ba9
Change the way installation happens in the actions script
bradhe 97f666c
Don't limit the installations to just what's local
bradhe c27b349
Final bits to make windows, linux, and mussllinux builds work/tested
bradhe e2999e9
chore: Yet another attempt to let maturin to do it's thing
bradhe 0c8f3ea
Fix formatting of code in a test
bradhe 3875d60
Stub for mypy. Shouldn't interfere with other stuff
bradhe 6a43ed5
Updates to integration tests for the new target
bradhe bfe5e5c
Enable builds on ARM64 targets on Windows
bradhe e1c2171
Some cleanup, please deleting a .so
bradhe 06df550
Share data between steps
bradhe 26896e8
A few fixes for the last set of failures
bradhe ee8a21c
chore: Add separate runner type for Windows ARM
bradhe bc02470
Addres some feedback from @konstantinoscs
bradhe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,6 +2,7 @@ | |
| /.venv | ||
| *.pyc | ||
| __pycache__ | ||
| *.so | ||
|
|
||
|
|
||
| # may contain sensitive data | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 1 addition & 2 deletions
3
crates/tower-runtime/tests/example-apps/03-legacy-app/requirements.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1 @@ | ||
| dlt[snowflake,filesystem]==1.4.0 | ||
| pandas | ||
| requests |
4 changes: 2 additions & 2 deletions
4
crates/tower-runtime/tests/example-apps/03-legacy-app/task.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| import dlt | ||
| import requests | ||
|
|
||
| print(dlt.version.__version__) | ||
| print(requests.__version__) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What changed and we need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had many interpreters available in the OS, we had to tell it specifically which one to use. It's complicated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I..... trust you