Conversation
Contributor
bradhe
commented
Jun 4, 2025
- Upgrades to the Tower API
- Fix some build-related issues
- Pass output channels to launchers to get output sooner
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the Tower API client for the v0.3.15 release by bumping the OpenAPI document version from v0.5.12 to v0.5.23, fixing build-related issues, and adding support for output channels in launchers. Key changes include:
- Updating the API version in many model and configuration files
- Refactoring alert-related models and corresponding API endpoints (e.g. renaming alert_id to alert_seq)
- Adding endpoints for password reset actions and updating related documentation
Reviewed Changes
Copilot reviewed 135 out of 135 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/tower-api/src/models/*.rs | Updated API version in several model files and refactored the Alert model (changed field types and removed enums) |
| crates/tower-api/src/apis/default_api.rs | Updated endpoint parameter names and added new endpoints for password reset, stream alerts, and update password reset |
| crates/tower-api/README.md | Updated documentation to reflect new endpoint paths and API version bump |
| Cargo.toml | Updated dependency settings and added the tower-telemetry crate |
Comments suppressed due to low confidence (2)
crates/tower-api/src/apis/default_api.rs:252
- Changing the type of the 'acked' parameter from Option to Option might introduce ambiguity. Consider whether a boolean (or an enum if more states are needed) better expresses the intended filtering behavior.
pub acked: Option<String>
crates/tower-api/src/models/alert.rs:15
- The modifications in the Alert struct—changing 'alert_type' from an enum to a String and replacing the 'details' field with a singular 'detail' of type Box—reduce type safety. Please ensure these changes are intentional with respect to API expectations and that all downstream consumers of these types are updated accordingly.
pub struct Alert {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.